prepare target for configuration changes to avoid conflict and/or race condition - #398
Merged
Conversation
…e condition Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a preparatory function to ready targets for configuration changes and adjusts dependency settings in various configuration scripts to avoid conflicts when running in parallel. Key changes include:
- Adding the prepareTarget function in config.go to run a pre-configuration script.
- Commenting out dependency declarations (Depends and Lkms) in several set functions.
- Updating the setELC function to include an additional dependency ("pcm-tpmi").
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/config/set.go | Commented out dependency fields in various set functions and updated setELC dependencies. |
| cmd/config/config.go | Introduced prepareTarget to prepare the target before running configuration scripts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new function to prepare targets for configuration changes and modifies dependencies and kernel module requirements across various configuration scripts. The changes aim to streamline the setup process and reduce potential conflicts during parallel execution of scripts.
New Functionality:
cmd/config/config.go: Added theprepareTargetfunction to handle pre-configuration setup, including loading themsrkernel module and preparing dependencies likewrmsrandrdmsr. This ensures that subsequent scripts can run in parallel without conflicts.Dependency Adjustments:
cmd/config/set.go: Commented outDependsandLkmsfields for multiple scripts (e.g.,wrmsr,rdmsr) across functions likesetLlcSize,setCoreFrequency,setUncoreFrequency,setTDP,setEPB,setEPP,setPrefetcher, andsetC1Demotion. These changes indicate that the dependencies are no longer explicitly required in the script definitions. [1] [2] [3] [4] [5] [6] [7] [8]Additional Dependency Inclusion:
cmd/config/set.go: Updated theDependsfield in thesetELCfunction to include"pcm-tpmi"alongside"bhs-power-mode.sh", reflecting new requirements for this script.